[Test] Extend test_essential_feature to also cover basic GPU workload leveraging CUDA Samples.#7401
Merged
gmarciani merged 2 commits intoMay 20, 2026
Conversation
… leveraging CUDA Samples.
…pes to reduce the risk of ICEs. Flexible instance type are cached to reduce the number of EC2 requests.
f590098 to
0c357ec
Compare
hehe7318
approved these changes
May 20, 2026
Contributor
hehe7318
left a comment
There was a problem hiding this comment.
Approve with a comment.
| echo "Node: $(hostname)" | ||
| echo "Sample: $SAMPLE_REL" | ||
| echo "SLURM_JOB_GPUS=${SLURM_JOB_GPUS:-unset}" | ||
| echo "CUDA_VISIBLE_DEVICES=${CUDA_VISIBLE_DEVICES:-unset}" |
Contributor
There was a problem hiding this comment.
[Minor] Do we need to explicitly set --gres=gpu to ensure GPU is visible?
Contributor
Author
There was a problem hiding this comment.
not in this case because we are targeting the queue that only has cr with GPUs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Extend test_essential_feature to also cover basic GPU workload leveraging CUDA Samples.
Tests
test_essential_featureand verified that it is using the expected 5 equivalent flex instance typesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.